Mint Forum

It looks like mint (specifically useragent007) is incorrectly identifying OS X 10.10 as 10.1. When I look at my stats, I’m starting to see a bunch of hits from OS X Puma. These didn’t show up until Yosemite was released.

I’m sure it has something to do with this regex, but I’m not a real expert at that:

if (preg_match(‘#Mac OS X (10[^;]+)#i’, $user_agent, $m))

Taking your code above, here is what I did:

if (preg_match(‘/10[0-9]+/’, $user_agent, $m)) { $build = str_replace(‘_’, ‘.’, $m[0]); $builds = array ( ‘10.0’ => ‘Cheetah’, ‘10.1’ => ‘Puma’, ‘10.2’ => ‘Jaguar’, ‘10.3’ => ‘Panther’, ‘10.4’ => ‘Tiger’, ‘10.5’ => ‘Leopard’, ‘10.6’ => ‘Snow Leopard’, ‘10.7’ => ‘Lion’, ‘10.8’ => ‘Mountain Lion’, ‘10.9’ => ‘Mavericks’, ‘10.10’ => ‘Yosemite’ );

When I do that, Mint no longer even renders properly. So I’m obviously doing something wrong.

This should fix it:

if (preg_match('#Mac OS X (10[^;]+)#i', $user_agent, $m))
{
    $build = rtrim(substr(str_replace('_', '.', $m[1]), 0, 5), '.');
    $builds = array
    (
        '10.0' => 'Cheetah',
        '10.1' => 'Puma',
        '10.2' => 'Jaguar',
        '10.3' => 'Panther',
        '10.4' => 'Tiger',
        '10.5' => 'Leopard',
        '10.6' => 'Snow Leopard',
        '10.7' => 'Lion',
        '10.8' => 'Mountain Lion',
        '10.9' => 'Mavericks',
        '10.10' => 'Yosemite',
        '10.11' => 'El Capitan'
    );